First class callable method crashes on undefined object variable

[michaeldnelson]

https://psalm.dev/r/16a7bedf08

$z = $x->do(...);

I would expect this to report undefined variable $x, instead it crashes with an internal error.

For additional context, I discovered this while trying recreate an assert(!$this->isFirstClassCallable()) error I keep getting in my project but was not able to reproduce in the online parser. I'm hoping it is related.

Thanks!

[psalm-github-bot]

I found these snippets:

https://psalm.dev/r/16a7bedf08

<?php

$z = $x->do(...);

Psalm encountered an internal error:

/vendor/vimeo/psalm/src/Psalm/Internal/Analyzer/Statements/Expression/Call/ArgumentsAnalyzer.php: Psalm\Internal\Analyzer\Statements\Expression\Call\ArgumentsAnalyzer::evaluateArbitraryParam(): Argument #2 ($arg) must be of type PhpParser\Node\Arg, PhpParser\Node\VariadicPlaceholder given, called in /vendor/vimeo/psalm/src/Psalm/Internal/Analyzer/Statements/Expression/Call/ArgumentsAnalyzer.php on line 127

[orklah]

Definitely related. Unfortunately, the online parser is badly configured and does not crash when asserting fail, so it just continues through it

[weirdan]

Reports UndefinedGlobalVariable now: https://psalm.dev/r/16a7bedf08

Likely fixed by #8814

[psalm-github-bot]

I found these snippets:

https://psalm.dev/r/16a7bedf08

<?php

$z = $x->do(...);

Psalm output (using commit 14d48a0):

ERROR: UndefinedGlobalVariable - 3:6 - Cannot find referenced variable $x in global scope

INFO: MixedMethodCall - 3:10 - Cannot determine the type of $x when calling method do

INFO: UnusedVariable - 3:1 - $z is never referenced or the value is not used