Taint not found inside "if" statement

[mmcev106]

Should this taint be reported?

https://psalm.dev/r/8c624220b8

[psalm-github-bot]

I found these snippets:

https://psalm.dev/r/8c624220b8

<?php // --taint-analysis

if(true){
	$a = $_GET['a'];
}

echo $a;

Psalm output (using commit f960d71):

No issues!

[AndrolGenhald]

Yes, but currently the type of $a is lost once the if scope ends. I have a branch I've done some work on to fix this, but I haven't had much time the past few months to finish it and get it working. Hopefully I'll have more time in a month or two, I'll add this as a test case to make sure it works.

[mmcev106]

Thanks for the info! I'm curious, which branch would that be?

[AndrolGenhald]

I think it's still local atm, it's failing a lot of tests and still needs quite a bit of work. I started working on loops and ifs after I got stuck on the same issue in #7688, since the variable not being defined outside of the if scope caused problems with my TryAnalyzer improvements.

[mmcev106]

@AndrolGenhald, any updates here? If not, would it make sense for that branch to be made public so that others might be able to help?

[orklah]

The branch is here if anyone want to look at it