Invalid provided type consolidation causes InvalidArgument error

[kkmuffme]

https://psalm.dev/r/ef73d1b6b4

I think there is a bug with the type consolidation, as the provided type in error is invalid
array{non-empty-list<string>, non-empty-list<string>}<non-empty-list<string>>

When I put the correct type, then no error https://psalm.dev/r/3549b6fa5a
However I think it needs to have the "provided" type fixed to a valid type, so the error message makes sense

[psalm-github-bot]

I found these snippets:

https://psalm.dev/r/ef73d1b6b4

<?php

$csv = array( 
    'foo,bar',
    'hello,world',
);
process( array_map( 'str_getcsv', $csv ) );


/**
 * @param array<int, string> $data
 * @return void
 */
function process( $data ) {
    print_r( $data );
}

Psalm output (using commit 6d45003):

ERROR: InvalidArgument - 7:10 - Argument 1 of process expects array<int, string>, array{non-empty-list<string>, non-empty-list<string>}<non-empty-list<string>> provided

https://psalm.dev/r/3549b6fa5a

<?php

$csv = array( 
    'foo,bar',
    'hello,world',
);
process( array_map( 'str_getcsv', $csv ) );


/**
 * @param array<int, string[]> $data
 * @return void
 */
function process( $data ) {
    print_r( $data );
}

Psalm output (using commit 6d45003):

No issues!

[AndrolGenhald]

array{non-empty-list<string>, non-empty-list<string>}<non-empty-list<string>> isn't a valid type annotation that a user can use, but it's how arrays with some known keys are represented internally. It's not great that we show a type that can't actually be used, but I'm waiting till I get around to doing index signature like arrays to fix this.

[psalm-github-bot]

I found these snippets:

https://psalm.dev/r/165b0a9c5c

<?php

/** @var array<string, float> */
$arr = [];
$arr[1] = 2;
$arr[4] = 3;
/** @psalm-trace $arr */;

Psalm output (using commit 6d45003):

INFO: Trace - 7:25 - $arr: array{1: 2, 4: 3}<string, float>

INFO: UnusedVariable - 4:1 - $arr is never referenced or the value is not used

[orklah]

Note that you can use this syntax like this:
https://psalm.dev/r/ff73b2dfb0

But I hate it. It's not an intersection at all. I'd rather we parse the original syntax

[psalm-github-bot]

I found these snippets:

https://psalm.dev/r/ff73b2dfb0

<?php
/** @var array{1: 2, 4: 3}&array<string, float> $array */
$array = '';

/** @psalm-trace $array */;

Psalm output (using commit 6d45003):

INFO: Trace - 5:27 - $array: array{1: 2, 4: 3}<string, float>

INFO: UnusedVariable - 3:1 - $array is never referenced or the value is not used

[kkmuffme]

So basically you are saying this issue could be fixed by just replacing }< with }&< in the error message? That would be a quick fix I could PR, which would solve this issue for the time being until those other things are implemented.

[orklah]

I wouldn't accept such a PR. That syntax need to be replaced, not normalized