Error with array references in Reconciler

[ohader]

https://psalm.dev/r/03af5df16f

Check XHR response in browser's dev console (actually it's "just" a warning, however analyzer stops)

Warning: Undefined array key "$doesNotMatter[$a]" in /var/www/vhosts/psalm.dev/httpdocs/vendor/vimeo/psalm/src/Psalm/Type/Reconciler.php on line 128
{"error":{"message":"\/vendor\/vimeo\/psalm\/src\/Psalm\/Type\/Reconciler.php: __clone method called on non-object","line_from":128,"type":"psalm_error"}}

psalm/src/Psalm/Type/Reconciler.php

Line 128 in e268a05

$existing_types[$referenced] = clone $old_existing_types[$referenced];

[psalm-github-bot]

I found these snippets:

https://psalm.dev/r/03af5df16f

<?php
$a = 'a';
$b = false;

$doesNotMatter = ['a' => ['id' => 1]];
// only the reference `&` seems to matter here
// check PHP error message in XHR response
// ```
// Warning: Undefined array key "$doesNotMatter[$a]" in /var/www/vhosts/psalm.dev/httpdocs/vendor/vimeo/psalm/src/Psalm/Type/Reconciler.php on line 128
// {"error":{"message":"\/vendor\/vimeo\/psalm\/src\/Psalm\/Type\/Reconciler.php: __clone method called on non-object","line_from":128,"type":"psalm_error"}}
// ```
$reference = &$doesNotMatter[$a];

// this comparison is also involved
// interesting that `$reference` is not accessed at all
$result = ($a === 'not-a' && ($b || false));

Psalm encountered an internal error:

/vendor/vimeo/psalm/src/Psalm/Type/Reconciler.php: __clone method called on non-object

[ohader]

@AndrolGenhald I just created a test-case for this, feel free to reuse them from PR #8290

[AndrolGenhald]

I'll try to get this fixed soon, but I've given up on further improving support for arrays and objects with references, they're (imo) incredibly buggy and unintuitive: https://3v4l.org/3RncH

[ohader]

Incredible, I was not aware of that flaw in PHP! 😮
For the time being I think, it would be enough to encapsulate those scenarios and just not process the buggy ones.