DOMNode childNodes expecting a DOMNodeList of DomNode instead of DOMNode

[cristianobaptista]

If you loop through each of the items in a childNodes list as DOMNode, like in the following code:

$dom = new \DOMDocument();
$node = new \DOMNode();

echo implode('', array_map(
    fn (\DOMNode $node): string => trim($dom->saveHTML($node)),
    iterator_to_array($node->childNodes)
));

Psalm will return the following error:

InvalidClass - Class, interface or enum DomNode has wrong casing (see https://psalm.dev/007)

This is happening on v4.8.1 due to wrong casing on the PropertiesMap for domnode that should be DOMNodeList<DOMNode> instead of DomNodeList<DomNode>.

This is the commit that introduced the bug: #5403

I also tried to replicate the issue using psalm.dev but was unable to: https://psalm.dev/r/0957fc5f47
Maybe it depends on the case sensitivity of the system running psalm.

[psalm-github-bot]

I found these snippets:

https://psalm.dev/r/0957fc5f47

<?php 

$html = implode('', [
    '<div>',
    '<ul>',
    '<li>ITEM 1</li>',
    '<li>ITEM 2</li>',
    '</ul>',
    '</div>',
]);
$dom = new \DOMDocument();
$dom->loadHtml($html);

$list = $dom->getElementsByTagName('ul')->item(0);

echo implode('', array_map(
    fn (\DOMNode $node): string => trim($dom->saveHTML($node)),
    iterator_to_array($list->childNodes)
));

Psalm output (using commit bb9aabe):

No issues!

[orklah]

Seems legit :)

Can you propose a PR? 🙂

[cristianobaptista]

Sure thing, here it is: #8577

[weirdan]

Fixed in #8577