PossiblyFalseOperand: false is not erased after > 0 comparison

[derrabus]

Found while testing 5.0.0-rc1

https://psalm.dev/r/72fd1e5782

A variable typed as int|false is compared with zero ($length > 0). Afterwards, Psalm correctly infers that it has to be 1 or higher (int<1, max>). But it still considers false to be possible although (false > 0) === false.

[psalm-github-bot]

I found these snippets:

https://psalm.dev/r/72fd1e5782

<?php

function formatVarchar(int|false $length): string
{
    return $length > 0 ? 'VARCHAR(' . $length . ')' : 'VARCHAR';
}

Psalm output (using commit 8f39de9):

ERROR: PossiblyFalseOperand - 5:39 - Cannot concatenate with a possibly false false|int<1, max>

[orklah]

Thanks for reporting!

Given that you tested the beta, this would be a new regression in the RC, correct?

[derrabus]

This happened on a different codebase than I tested the beta on. I can't tell whether the beta was affected already, sorry.

[derrabus]

Thank you for the quick bugfix! 🚀