Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow PHP 8.2 for Phar usage in composer.json #8747

Closed
cracksalad opened this issue Nov 24, 2022 · 8 comments
Closed

Allow PHP 8.2 for Phar usage in composer.json #8747

cracksalad opened this issue Nov 24, 2022 · 8 comments

Comments

@cracksalad
Copy link

I am using psalm as a phar via phive. Executing it results in the following error message.

Box Requirements Checker
========================
> Using PHP 8.2.0RC6
> PHP is using the following php.ini file:
  WARNING: No configuration file (php.ini) used by PHP!
> Checking Box requirements:
  E...........
                                                                                
 [ERROR] Your system is not ready to run the application.                       
                                                                                
Fix the following mandatory requirements:
=========================================
 * The application requires the version "^7.4 || ~8.0.0 || ~8.1.0" or greater.

I am not sure but I assume that the require php value in composer.json should be updated to allow PHP 8.2 and thereby allow the execution in PHP 8.2. The composer.json contains exactly the same statement as shown in the last line of the error message:

[...]
  "require": {
        "php": "^7.4 || ~8.0.0 || ~8.1.0",
[...]
@psalm-github-bot
Copy link

Hey @Andi2405, can you reproduce the issue on https://psalm.dev ?

@cracksalad
Copy link
Author

Hey @Andi2405, can you reproduce the issue on https://psalm.dev ?

Sorry @psalm-github-bot , this is not helpful in this case. Refering to phar usage only

@orklah
Copy link
Collaborator

orklah commented Nov 24, 2022

Note 1: This applies to master branch (so Psalm 5 release)
Note 2: we didn't try to run our CI on PHP 8.2 yet so we have to do that before adding 8.2 in composer.json

Let's see if we can do that before releasing

@orklah orklah mentioned this issue Nov 24, 2022
@orklah orklah closed this as completed in 203d2c2 Nov 24, 2022
@orklah orklah reopened this Nov 24, 2022
@orklah
Copy link
Collaborator

orklah commented Nov 24, 2022

I made #8752 to test the CI on 8.2

We currently depends on prophecy who does not allow 8.2 yet so dependencies can't be resolved as of now. We'll have to wait until it does (or make changes to stop depending on it).

I suggest using 8.1 for the foreseeable future

@weirdan
Copy link
Collaborator

weirdan commented Nov 25, 2022

or make changes to stop depending on it

It's done; we're now using Mockery instead.

@cracksalad
Copy link
Author

Great news, thank you very much! I guess I can expect a new release (candidate) in the next few days to weeks, right?

@weirdan
Copy link
Collaborator

weirdan commented Nov 25, 2022

I don't have 8.2 locally. Would you mind checking whether https://output.circle-artifacts.com/output/job/425711a7-0268-4aec-93ff-da3a7a865eef/artifacts/0/build/psalm.phar works for you?

@cracksalad
Copy link
Author

cracksalad commented Nov 25, 2022

It totally works for me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants