Hard to get symbol in some issues for plugins

[jack-worman]

I am trying to write a plugin that will suppress UnusedProperty if it is a doctrine column. But I am struggling to retrieve the symbol (class name and property name) to do the reflection to achieve this.

My code would looks something like this:

<?php

declare(strict_types=1);

namespace App\Psalm\Hook;

use Psalm\Issue\UnusedProperty;
use Psalm\Plugin\EventHandler\BeforeAddIssueInterface;
use Psalm\Plugin\EventHandler\Event\BeforeAddIssueEvent;

class DoctrinePropertySuppressUnusedHook implements BeforeAddIssueInterface
{
    public static function beforeAddIssue(BeforeAddIssueEvent $event): ?bool
    {
        $codeIssue = $event->getIssue();
        if ($codeIssue instanceof UnusedProperty) {
            // $class = ...
            // $property = ...
            // TODO: Use reflection to test for ORM attributes
        }
        return null;
    }
}

Is there a better way to do this?
Or should fully qualified symbol names be added to issues?

[psalm-github-bot]

Hey @jack-worman, can you reproduce the issue on https://psalm.dev ?

[orklah]

Seems like UnusedProperty doesn't inherit PropertyIssue:

psalm/src/Psalm/Issue/UnusedProperty.php

Line 5 in a331ac0

final class UnusedProperty extends CodeIssue

If it was, you'd be able to retrieve the property_id:

psalm/src/Psalm/Issue/PropertyIssue.php

Line 12 in 97e6511

public $property_id;

You could PR that change if you want

[jack-worman]

This was already done by @weirdan in another issue. :)

[weirdan]

Yep, in #8883