DOMDocument::$preserveWhitespace should be reported as dynamic property. Not $preserveWhiteSpace

[sasezaki]

Hi. I noticed that psalm would not report DOMDocument::$preserveWhitespace is dynamic property.
( When after I saw this commit php/doc-base@9965c2b )

php-src declares as preserveWhiteSpace .
https://github.com/php/php-src/blob/027add9e1bf935c2d874f736105cced87fdeb226/ext/dom/php_dom.stub.php#L679

<?php

$dom = new DOMDocument;
$dom->preserveWhiteSpace = false;
$dom->preserveWhitespace = false; // should be reported as dynamic property

$dom->PreserveWhitespace = false; // ERROR: UndefinedPropertyAssignment
$dom->preservewhitespace = false; // ERROR: UndefinedPropertyAssignment

// PropertyMap  `'strictErrorChecking' => 'bool',` 
$dom->strictErrorChecking = false;
$dom->strictErrorchecking = false;

https://psalm.dev/r/a2760ed2e5

It seems current PropertyMap is mistaken.

'preserveWhitespace' => 'bool',

psalm/dictionaries/PropertyMap.php

Line 116 in 5afc328

'preserveWhitespace' => 'bool',

But I don't know why currently $dom->preserveWhiteSpace is not reported as ERROR against case sensitive...

[psalm-github-bot]

I found these snippets:

https://psalm.dev/r/a2760ed2e5

<?php

$dom = new DOMDocument;
$dom->preserveWhiteSpace = false;
$dom->preserveWhitespace = false; // should be reported as dynamic property

$dom->PreserveWhitespace = false;
$dom->preservewhitespace = false;

// PropertyMap  `'strictErrorChecking' => 'bool',` 
$dom->strictErrorChecking = false;
$dom->strictErrorchecking = false;

Psalm output (using commit ef02ded):

ERROR: UndefinedPropertyAssignment - 7:1 - Instance property DOMDocument::$PreserveWhitespace is not defined

ERROR: UndefinedPropertyAssignment - 8:1 - Instance property DOMDocument::$preservewhitespace is not defined

ERROR: UndefinedPropertyAssignment - 12:1 - Instance property DOMDocument::$strictErrorchecking is not defined

[weirdan]

Psalm seems to think both are present: https://psalm.dev/r/3015ffd278

[psalm-github-bot]

I found these snippets:

https://psalm.dev/r/3015ffd278

<?php

$dom = new DOMDocument;
$v = get_object_vars($dom);        
/** @psalm-trace $v */;

Psalm output (using commit ef02ded):

INFO: Trace - 5:23 - $v: array{actualEncoding: null|string, attributes: DOMNamedNodeMap|null, baseURI: null|string, childElementCount: int, childNodes: DOMNodeList<DOMNode>, config: mixed, doctype: DOMDocumentType|null, documentElement: DOMElement|null, documentURI: null|string, encoding: null|string, firstChild: DOMNode|null, firstElementChild: DOMElement|null, formatOutput: bool, implementation: DOMImplementation, lastChild: DOMNode|null, lastElementChild: DOMElement|null, localName: null|string, namespaceURI: null|string, nextSibling: DOMNode|null, nodeName: string, nodeType: int, nodeValue: null|string, ownerDocument: DOMDocument|null, parentNode: DOMNode|null, prefix: string, preserveWhiteSpace: bool, preserveWhitespace: bool, previousSibling: DOMNode|null, recover: bool, resolveExternals: bool, standalone: bool, strictErrorChecking: bool, substituteEntities: bool, textContent: string, validateOnParse: bool, version: null|string, xmlEncoding: null|string, xmlStandalone: bool, xmlVersion: null|string, ...<string, mixed>}

INFO: UnusedVariable - 4:1 - $v is never referenced or the value is not used

[weirdan]

'preserveWhiteSpace' likely comes from reflection, while 'preserveWhitespace' is from the property map.

[sasezaki]

@weirdan

Thanks for advice! I made PR at #8918.