Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recent sprintf changes #8946

Closed
jack-worman opened this issue Dec 19, 2022 · 1 comment
Closed

Recent sprintf changes #8946

jack-worman opened this issue Dec 19, 2022 · 1 comment

Comments

@jack-worman
Copy link
Contributor

jack-worman commented Dec 19, 2022

Concerns about the changes in #8922:

The new return type is not always true. Here is a counter example:
var_dump(sprintf('%s', '', 'x')); // string(0) ""

And this also does not figure out this is a non-empty-string:
var_dump(sprintf('%s%s', '', 'x')); // string(0) "x"

@jack-worman
Copy link
Contributor Author

jack-worman commented Dec 19, 2022

Nevermind, I think I am wrong because it defaults back to just string when there are more than 2 args

@jack-worman jack-worman closed this as not planned Won't fix, can't repro, duplicate, stale Dec 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant