Broken magic properties

[danog]

https://psalm.dev/r/5c15139bd5, caused by #9656, working on a fix...

[psalm-github-bot]

I found these snippets:

https://psalm.dev/r/5c15139bd5

<?php

/** @property int $content */
class a {
    public function __get($name)
    {
        return 0;
    }
}

/** @var a&object{__tempProperties: "lmao"} */
$r = null;
/** @psalm-trace $v */
$v = $r->content;

Psalm output (using commit a97b6b8):

INFO: MixedAssignment - 14:1 - Unable to determine the type that $v is being assigned to

INFO: Trace - 14:1 - $v: mixed

INFO: UnusedVariable - 14:1 - $v is never referenced or the value is not used

INFO: MissingParamType - 5:27 - Parameter $name has no provided type

[orklah]

are we sure that's what we want?

Intersecting an object with a content property and another object with a __tempProperties is pretty weird, no? Shouldn't that be a union?

[danog]

That's an internal detail, our plugin uses intersections to represent "temporary" properties that may be attached to an object (ugly, I know, will phase them out completely eventually).
The crux of the issue is that property fetches on an intersection of a shaped object and a named object are broken.