SprintfReturnTypeProvider not working well with array unpacking

[fancyweb]

Hello, SprintfReturnTypeProvider crashes when sprintf is used with array unpacking because it considers there's one arg only, eg:

$array = ['foo', 'bar', 'ccc'];
sprintf('%s %s %s', ...$array);

[psalm-github-bot]

Hey @fancyweb, can you reproduce the issue on https://psalm.dev ?

[fancyweb]

Some real code that shows the bug: https://github.com/symfony/symfony/pull/50565/files

[fancyweb]

https://psalm.dev/r/260236cf5b

[psalm-github-bot]

I found these snippets:

https://psalm.dev/r/260236cf5b

<?php

$a = ['foo', 'bar', 'ccc'];
sprintf('%s %s %s', ...$a);

Psalm encountered an internal error:

/vendor/vimeo/psalm/src/Psalm/Internal/Provider/ReturnTypeProvider/SprintfReturnTypeProvider.php: 4 arguments are required, 2 given

[kkmuffme]

This is partially (= the fatal error) fixed in #9877, however in this case you should probably use vsprintf instead of sprintf anyway.
We should perhaps add an error for that (ArgumentTypeCoercion?) to use vsprintf in that case, but also handle it that it won't report TooFewArguments error.

[mrVrAlex]

@orklah @kkmuffme PR not full resolved this issue, look this case: https://psalm.dev/r/308b6b4ae5
Should I open new bug issue? Or just re-open it? (In v5.12 it is produce no errors)

[psalm-github-bot]

I found these snippets:

https://psalm.dev/r/308b6b4ae5

<?php

$a = ['Some %s error', 1];
echo sprintf(...$a);

Psalm output (using commit 086b943):

ERROR: TooFewArguments - 4:6 - Too few arguments for sprintf, expecting at least 2 arguments

[kkmuffme]

Fixed in #9975