Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace array<never, never> as a way to detect empty arrays by a dedicated method #7313

Merged
merged 3 commits into from Jan 5, 2022

Conversation

orklah
Copy link
Collaborator

@orklah orklah commented Jan 5, 2022

This is a pattern we had on different places but it's not great because technically, array<array-key, never> is also an empty array.

@orklah orklah added the release:internal The PR will be included in 'Internal changes' section of the release notes label Jan 5, 2022
@orklah orklah merged commit bf4bf92 into vimeo:master Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:internal The PR will be included in 'Internal changes' section of the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants