Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix code where the offset was wrong #7463

Merged
merged 1 commit into from Jan 22, 2022
Merged

fix code where the offset was wrong #7463

merged 1 commit into from Jan 22, 2022

Conversation

orklah
Copy link
Collaborator

@orklah orklah commented Jan 22, 2022

This is a weird error I noticed when working on #7461

These properties are always called with a $ in front of property name

It seems to be a net positive because it started to flag a case where a string was used instead of class-string, but it's in a stub and the property is present twice, once in a @Property and one in real code. Weird that it wasn't triggered by the real code one

@orklah orklah added the release:fix The PR will be included in 'Fixes' section of the release notes label Jan 22, 2022
@orklah orklah merged commit e0d3c3f into vimeo:master Jan 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:fix The PR will be included in 'Fixes' section of the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant