From 4ee8a80a1720cb499674462715ac024234a8904c Mon Sep 17 00:00:00 2001 From: Bruce Weirdan Date: Sun, 13 Feb 2022 07:09:28 +0200 Subject: [PATCH] Use array_fill_keys There was a number of calls to `array_map(fn()=>true, array_flip($array))` that got replaced with a simpler (and more performant) `array_fill_keys($array, true)` --- .../Internal/Provider/StatementsProvider.php | 23 ++++--------------- 1 file changed, 4 insertions(+), 19 deletions(-) diff --git a/src/Psalm/Internal/Provider/StatementsProvider.php b/src/Psalm/Internal/Provider/StatementsProvider.php index 03df6b2f113..f78bd3e83b9 100644 --- a/src/Psalm/Internal/Provider/StatementsProvider.php +++ b/src/Psalm/Internal/Provider/StatementsProvider.php @@ -21,7 +21,7 @@ use Throwable; use function abs; -use function array_flip; +use function array_fill_keys; use function array_intersect_key; use function array_map; use function array_merge; @@ -216,15 +216,8 @@ public function getStatementsForFile( $file_contents ); - $unchanged_members = array_map( - fn(int $_): bool => true, - array_flip($unchanged_members) - ); - - $unchanged_signature_members = array_map( - fn(int $_): bool => true, - array_flip($unchanged_signature_members) - ); + $unchanged_members = array_fill_keys($unchanged_members, true); + $unchanged_signature_members = array_fill_keys($unchanged_signature_members, true); $file_path_hash = md5($file_path); @@ -239,15 +232,7 @@ function (string $key) use ($file_path_hash): string { $changed_members ); - $changed_members = array_map( - /** - * @param int $_ - * - * @return bool - */ - fn($_): bool => true, - array_flip($changed_members) - ); + $changed_members = array_fill_keys($changed_members, true); if (isset($this->unchanged_members[$file_path])) { $this->unchanged_members[$file_path] = array_intersect_key(