fix refining lowercase string and non-empty-string together #7844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orklah
added
the
release:fix
|
Failure is unrelated, I'll have to check that later |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #7843 (on Psalm 5 though...)
For the explanation: Psalm assertions works well when one of the two type is a super type of another (isContainedBy method). When that happens, Psalm just takes the narrower type and goes on. Issues arise when none of the type is completely included in another. (A great example is the condition just above with
int<0, 10>andint<5, 15>which should result inint<5, 10>but need to be handled separately).This is the same with non-empty-string and lowercase-string, the intersection of both is possible within Psalm's type system (non-empty-lowercase-string) but none is completely included in the other