Merge 4.x to master. #8222
Merge 4.x to master. #8222
Conversation
They were caused by installing packages with `--ignore-platform-reqs` which brought PHP 8.1 autoloaded packages and caused fatal errors when running php-parallel-lint. Instead of ignoring platform requirements we now remove packages that are incompatible with PHP 7.1 (phpunit and its dependents).
Because installing packages with 8.1 and checking them as if we're running 7.1 just doesn't work.
Run Shepherd with 8.0
Precise stat return type
…ect-fputcsv-invalidnamedargument Bugfix/splfileobject fputcsv invalidnamedargument
This keeps coming up in obscure places, hopefully this fixes it once and for all. I would reeeaaally love to have an immutable type system at some point...
…ation Fix `TypeCombiner::combine` to not modify TIntRange arguments.
instead of from full text 50% faster than cutting from full text, improves performance up to 3% depending on file length and number of errors in file
…text-from-snippet Performance: cut the selected_text from snippet
…tion store origin location by ID to speed up psalm by up to 75%
I wasn't sure from reading the docs whether or not Psalm consider zero to be positive.
Clarify in docs that zero is not considered a positive-int
Fixes vimeo#8063 Alters the fix for vimeo#2165 (1a48be8) /cc: @iluuu1994, @muglug
…array-offsets Coerce null to empty string in array keys
…irc/skip-duplicate-actions-4.0.0 build(deps): bump fkirc/skip-duplicate-actions from 3.4.0 to 4.0.0
…tions/cache-3 build(deps): bump actions/cache from 2 to 3
…tions/checkout-3 build(deps): bump actions/checkout from 2 to 3
Allow testing expected CallMap return types
Fix several CallMap function signatures
Fix codestyle errors in InternalCallMapHandlerTest
fix: ltrim may return class-string vimeo#8218
AndrolGenhald
added
the
release:internal
|
Check PHP syntax is failing because it can't remove phpunit, running the suggested command gives: I have no idea why this would be happening on this pull request and not on current master though. |
|
The "Drop incompatible packages" step is present in 4.x after cache composer: So I guess GH run the 4.x CI on your PR |
|
Oh, that's actually a change in your merge PR: https://github.com/vimeo/psalm/pull/8222/files#diff-b803fcb7f17ed9235f1e5cb1fcd2f5d3b2838429d4368ae4c57ce4436577f03fR37 EDIT: it was added in: #8028. It may not be relevant in master. @weirdan do you have thoughts on this? |
|
🤦 I should have checked that. Yeah, it's probably not relevant, If weirdan doesn't get back to us in a day or so I'll just remove it and see if the tests all pass. |
|
That step was required to get CI (that particular job) working on PHP 7.1. It's not required to run the job on 7.4 (the minimum supported version for 5.x) and so could be removed in |
|
@AndrolGenhald can you check if failure in real project is legit? |
|
It looks like a true positive to me, but it's not showing up on either 4.x or the current master. I'll investigate it further in a bit. |
|
Next time I'm checking the baseline before going and debugging the whole thing... It's because the type changed from I'm going to keep looking into why the type changed, I would think that would still be |
|
Don't bother too much, the goal is just to make sure there isn't something fundamentally broken. There will always be fringe edge cases when doing massive changes. The master branch is already pretty heavy so it's bound to happen |
|
Turns out it was actually one of my changes that made |
No description provided.