Fix type reconciliation breaking Context::$references_in_scope (fixes #8289). #8306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrolGenhald
added
the
release:fix
|
Congrats on becoming the world expert on PHP references 😄 ! That's mumbo jumbo to me ! Thanks! |
|
Wow! Awesome and thanks a bunch! I just used this change in a project that failed previously... works like a charm now! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks @ohader re #8290!
The problem here was that the reconciliation due to the comparison on
$acaused$doesNotMatter[$a]to be removed from$existing_types(which later gets assigned toContext::$vars_in_scope), butContext::$references_in_scopestill had$referencepointing to"\$doesNotMatter[\$a]".