Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup outdated comment #8699

Merged
merged 1 commit into from Nov 11, 2022
Merged

Cleanup outdated comment #8699

merged 1 commit into from Nov 11, 2022

Conversation

andrew-demb
Copy link
Contributor

Follow-up for #8694

@weirdan weirdan added the release:typo The PR will be included in 'Typos' section of the release notes label Nov 11, 2022
@weirdan
Copy link
Collaborator

weirdan commented Nov 11, 2022 •
edited

@andrew-demb I think CircleCI failure can be fixed by you following the steps in If you're following the fork instead of the upstream repo section of https://support.circleci.com/hc/en-us/articles/360008097173-Troubleshooting-why-pull-requests-are-not-triggering-jobs-on-my-organization-

@andrew-demb
Copy link
Contributor Author

@andrew-demb I think CircleCI failure can be fixed by you following the steps in If you're following the fork instead of the upstream repo section of https://support.circleci.com/hc/en-us/articles/360008097173-Troubleshooting-why-pull-requests-are-not-triggering-jobs-on-my-organization-

Probably it was a case described in "If the branch and the pull request happen to be created simultaneously" chapter

@weirdan
Copy link
Collaborator

weirdan commented Nov 11, 2022

Or that.

@weirdan weirdan merged commit efe3627 into vimeo:master Nov 11, 2022
@weirdan
Copy link
Collaborator

weirdan commented Nov 11, 2022

Thanks!

@andrew-demb andrew-demb deleted the patch-1 branch November 11, 2022 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
release:typo The PR will be included in 'Typos' section of the release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@andrew-demb @weirdan