-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update parameter caching table #1511
Comments
I did an audit on A. Static limitsCount: 56 These used to be cached after the first query, and after #1510 are no longer cached. We can either whitelist these, or add special handling for the other categories and then fall back to always caching. B. Cached by setters but not listed in defaultsCount: 2 These used to be cached after the first query, and after #1510 are only cached if the setter is called. We should just add these to the defaults table.
C. Dynamic parameters whose setters are not interceptedCount: 19
We can either start to intercept their setters -- I'm unsure about the perf and bundle size implications -- or blacklist them from being cached.
D. Dynamic parameters that depend on another parameterCount: 5
We need to either add the ability to delete a cache within a setter, or blacklist these from being cached.
|
See discussion in #1510
TODO
Update GL_PARAMETER_DEFAULTS to include static WebGL limits, reference:
https://developer.mozilla.org/en-US/docs/Web/API/WebGLRenderingContext/getParameter
The text was updated successfully, but these errors were encountered: