Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Picking not working with uniform block #1850

Open
felixpalmer opened this issue Nov 29, 2023 · 2 comments
Open

Picking not working with uniform block #1850

felixpalmer opened this issue Nov 29, 2023 · 2 comments
Assignees

Comments

@felixpalmer
Copy link
Collaborator

Actual Result

When adding this picking module to a Model an error is raised:

Uncaught Error: No value for binding pickingUniforms in unnamed
    at WEBGLRenderPipeline._applyBindings (webgl-render-pipeline.ts:405:15)
    at WEBGLRenderPipeline.draw (webgl-render-pipeline.ts:242:10)
    at _Model.draw (model.ts:240:19)
    ...

Expected Result

Picking module can be added without issue

Reproduce Steps

Modify examples/tutorials/hello-cube/app.ts so that this.model contains modules: [picking] (import {picking} from '@luma.gl/shadertools';)

@ibgreen
Copy link
Collaborator

ibgreen commented Nov 29, 2023

picking module is used in the instancing example with some explicit handling.

I expect that you are looking for luma to automatically initialize and bind the uniform buffer?

@felixpalmer
Copy link
Collaborator Author

Yes that would be nice. I will try and follow the instancing example to get it working in deck

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants