Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds README section regarding usage in child procs #850

Merged
merged 2 commits into from Oct 13, 2021

Conversation

kristofkalocsai
Copy link
Contributor

code example and original request copied from @aaarichter
should close #811

code example and original request copied from @aaarichter
should close debug-js#811
Copy link
Member

@Qix- Qix- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this PR, just a small change.

README.md Outdated Show resolved Hide resolved
Co-authored-by: Qix <Qix-@users.noreply.github.com>
@kristofkalocsai
Copy link
Contributor Author

kristofkalocsai commented Oct 4, 2021

could you please add the label hacktoberfest-accepted if you merge the PR?

@Qix-
Copy link
Member

Qix- commented Oct 4, 2021

I would really rather not as it attracts really spammy contributions, thus I tend not to 'participate' in Hacktoberfest. However I've tweeted at them to see if there's a way to still give you credit somehow without opening up this repo to an onslaught of spam.

Let's see what they say :)

@kristofkalocsai
Copy link
Contributor Author

kristofkalocsai commented Oct 4, 2021

Understandable :D
Thanks for going the extra mile, appreciated!

@Qix-
Copy link
Member

Qix- commented Oct 13, 2021

Hey I've not received a response but I'd still like to merge this. Are you okay if this doesn't get recognized by Hacktoberfest? Sorry about that.

Feel free to reach out to them and comment back here with something I can do either now or post-merge to singularly mark this as having participated.

@kristofkalocsai
Copy link
Contributor Author

Of course, go ahead, thanks!

@Qix- Qix- merged commit f851b00 into debug-js:master Oct 13, 2021
@Qix-
Copy link
Member

Qix- commented Oct 13, 2021

Thank you so much :) Very appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Request: Add small note in README for using debug in child processes
2 participants