Invalid redirect in pipe

[louisbuchbinder]

There is a bug in redirects during a pipe. If the request responds with a redirect status, but an empty Location header then superagent will throw Uncaught TypeError: Cannot read property '_pipeContinue' of undefined.

To reproduce you can checkout my tests (without the patch) and run them. You will see:

 330 passing (8s)                               
  5 pending                                
  1 failing                                      
                                             
  1) request pipe should not throw on bad redirects:          
     Uncaught TypeError: Cannot read property '_pipeContinue' of undefined
      at ClientRequest.req.once.res (lib/node/index.js:414:33)
      at HTTPParser.parserOnIncomingClient [as onIncoming] (_http_client.js:543:21)
      at HTTPParser.parserOnHeadersComplete (_http_common.js:112:17)
      at Socket.socketOnData (_http_client.js:440:20)
      at addChunk (_stream_readable.js:263:12)
      at readableAddChunk (_stream_readable.js:250:11)
      at Socket.Readable.push (_stream_readable.js:208:10)
      at TCP.onread (net.js:597:20)  

or you can reproduce with by hand with something like:

http.createServer((req, res) => {
  res.setHeader('Location', '');
  res.statusCode = 302;
  res.end();
}).listen(8000);

require('superagent').get('localhost:8000/').pipe(require('fs').createWriteStream('./temp'));

[louisbuchbinder]

added a test for pipes with a good redirect

[louisbuchbinder]

I realize now there is already a test for a good redirect in ./test/node/pipe-redirect.js

[louisbuchbinder]

added a test to prove that redirects with a missing Location will not throw and error.

[louisbuchbinder]

added *.swp to the gitignore for vim files

[louisbuchbinder]

failing tests in node10 and 11... updating

Edit: Tests now passing in Travis for all node versions 6, 8, 10, and 11.

[louisbuchbinder]

On second thought, superagent should not be responsible for ending the client stream if there is an error. Instead the client should listen for the error event and then handle their stream on their own.

[louisbuchbinder]

please advise...

[niftylettuce]

@louisbuchbinder could you please refactor/pull latest from master? may be easiest to start fresh. would love to get this added to v5.x release that just came out.

[louisbuchbinder]

@niftylettuce I rebased and update for the linting rules

[niftylettuce]

@louisbuchbinder v5.0.4 is released, thank you