feat: add lookup method #1595
Merged
feat: add lookup method #1595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Released in v7.1.0 to npm https://github.com/visionmedia/superagent/releases/tag/v7.1.0 |
niftylettuce
added a commit
that referenced
this pull request
Jan 19, 2022
This reverts commit df06131.
|
This caused a break in v7.1.0 and I had to revert in v7.1.1 Please submit a new PR with the fix when you can, thank you |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the feature of custom DNS resolve in node.
Sometime we use custom DNS to do service discovery, but superagent doesn't have the ability of changing the lookup method when call node's http.request method.
So I pull this request to solve the problem.