feat: add github action #1677

yunnysunny · 2022-01-21T13:57:09Z

I have done some work on bringing github action on current project. In the process of that, I also found some problems.

First, the test on low version node is not supported now (https://github.com/yunnysunny/superagent/runs/4895023400). Since we use a newest version of eslint (8.3.0 in fact), it will emit an error when we run it on node 10.x :

Oops! Something went wrong! :(

ESLint: 8.6.0

TypeError: Module.createRequire is not a function
    at Object.<anonymous> (/home/runner/work/superagent/superagent/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:2359:26)
    at Module._compile (/home/runner/work/superagent/superagent/node_modules/v8-compile-cache/v8-compile-cache.js:192:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:789:10)
    at Module.load (internal/modules/cjs/loader.js:653:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:593:12)
    at Function.Module._load (internal/modules/cjs/loader.js:585:3)
    at Module.require (internal/modules/cjs/loader.js:692:17)
    at require (/home/runner/work/superagent/superagent/node_modules/v8-compile-cache/v8-compile-cache.js:159:20)
    at Object.<anonymous> (/home/runner/work/superagent/superagent/node_modules/eslint/lib/cli-engine/cli-engine.js:33:5)
    at Module._compile (/home/runner/work/superagent/superagent/node_modules/v8-compile-cache/v8-compile-cache.js:192:30)

We have to reduce the version of eslint , or skip the lint for node 10 , which needs an refactor of our ci code.

Second, the test of browsers failed with such error (https://github.com/yunnysunny/superagent/runs/4895413544):

SAUCE_APPIUM_VERSION=1.7 ./node_modules/.bin/zuul -- test/*.js test/client/*.js
(node:2010) [DEP0022] DeprecationWarning: os.tmpDir() is deprecated. Use os.tmpdir() instead.
- testing: chrome @ Mac 11: 97
- testing: firefox @ Mac 10.12: 96
- testing: safari @ Mac 12: 15
- testing: internet explorer @ Windows 2008: 9 10 11
- restarting: <safari 15 on Mac 12>
- restarting: <internet explorer 10 on Windows 2008>
- restarting: <chrome 97 on Mac 11>
- restarting: <firefox 96 on Mac 10.12>
- restarting: <internet explorer 9 on Windows 2008>
- restarting: <internet explorer 10 on Windows 2008>
- restarting: <chrome 97 on Mac 11>
- restarting: <safari 15 on Mac 12>
- restarting: <firefox 96 on Mac 10.12>
- restarting: <internet explorer 9 on Windows 2008>
- restarting: <chrome 97 on Mac 11>
- restarting: <internet explorer 10 on Windows 2008>
- restarting: <chrome 97 on Mac 11>
- restarting: <internet explorer 10 on Windows 2008>
- restarting: <safari 15 on Mac 12>
- restarting: <chrome 97 on Mac 11>
- restarting: <internet explorer 10 on Windows 2008>
- restarting: <firefox 96 on Mac 10.12>
- restarting: <internet explorer 9 on Windows 2008>
- restarting: <safari 15 on Mac 12>
- restarting: <chrome 97 on Mac 11>
- restarting: <internet explorer 10 on Windows 2008>
- restarting: <internet explorer 9 on Windows 2008>
- restarting: <safari 15 on Mac 12>
- failed: <internet explorer 11 on Windows 2008> (0 failed, 0 passed)
- restarting: <internet explorer 9 on Windows 2008>
- failed: <chrome 97 on Mac 11> (0 failed, 0 passed)

/home/runner/work/superagent/superagent/node_modules/zuul/bin/zuul:332
            throw err.message;
            ^
internet explorer@10: localtunnel server returned an error, please try again
(Use `node --trace-uncaught ...` to show where the exception was thrown)

I'm not familiar with zuul, and have no idea what happened.

Third, the test on http2 also failed(https://github.com/yunnysunny/superagent/runs/4895023445). It showed many errors , all of them with same reason, this is an example :

  1) request
       persistent agent
         should gain a session on POST:
     Uncaught Error [ERR_HTTP2_STREAM_ERROR]: Stream closed with error code NGHTTP2_PROTOCOL_ERROR
      at ClientHttp2Stream._destroy (internal/http2/core.js:2212:13)
      at ClientHttp2Stream.destroy (internal/streams/destroy.js:38:8)
      at Http2Stream.onStreamClose (internal/http2/core.js:518:12)

For the problems above, I drop the test of low version nodes, browsers, and http2 in the github action's yml.

niftylettuce · 2022-01-22T17:40:09Z

Is this good to merge?

yunnysunny · 2022-01-23T04:30:29Z

Yes. All the unsupported tests mentioned above have been ignored. It will show green status after run tests. We can fix the three problems above some time.
We can preview the result of github action in my repository https://github.com/yunnysunny/superagent/actions/runs/1728898488

yunnysunny · 2022-02-10T06:33:57Z

I think it's important to merge this request, since current project doesn't have an autotest flow. When another new pull request is been merged, we can't distingish whether it's ok.

titanism · 2022-03-29T03:15:50Z

v7.1.2 released https://github.com/visionmedia/superagent/releases/tag/v7.1.2

yunnysunny · 2022-03-29T03:26:47Z

I find a error in ci, when test on node 14, a case was failed:

  1) req.query(Object)
       query-string should be sent on pipe:
     Error: Timeout of 5000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (/home/runner/work/superagent/superagent/test/node/query.js)
      at listOnTimeout (internal/timers.js:557:17)
      at processTimers (internal/timers.js:500:7)

https://github.com/visionmedia/superagent/runs/5730870741?check_suite_focus=true

titanism · 2022-03-29T03:32:45Z

I re-ran the failed build on node v14 in GitHub CI and it failed again, so I will unpublish in the interim until you confirm it is OK or submit a PR to fix

seancolyer · 2022-04-01T13:15:08Z

It would be beneficial to move the SAUCE_USERNAME and SAUCE_ACCESS_KEY to use github secrets for the project, then they can be referenced simply as ${{ secrets.SAUCE_ACCESS_KEY}} in the actions file and not directly be part of source.

Not sure if this had been discussed before, but just noted it while reviewing upgrades 7.1.1 -> 7.1.2

yunnysunny · 2022-04-02T02:00:50Z

It would be beneficial to move the SAUCE_USERNAME and SAUCE_ACCESS_KEY to use github secrets for the project, then they can be referenced simply as ${{ secrets.SAUCE_ACCESS_KEY}} in the actions file and not directly be part of source.

Not sure if this had been discussed before, but just noted it while reviewing upgrades 7.1.1 -> 7.1.2

Has pulled a request (#1717) to resolve it.
But the test on browser failed with error message about zuul. I'm not familiar with it, so I just skip the test on browser in CI.

yunnysunny · 2022-04-03T05:14:22Z

#1716

I re-ran the failed build on node v14 in GitHub CI and it failed again, so I will unpublish in the interim until you confirm it is OK or submit a PR to fix

Try to fix it #1716

ladjs/superagent#1677

titanism · 2022-04-18T19:07:36Z

@yunnysunny pending results of https://github.com/visionmedia/superagent/actions/runs/2185564459, please follow up if we forget to version bump if successful

priyanka-kahare-kr · 2022-04-18T19:17:59Z

Is this package still deprecated ? Looks like this PR has been merged in?

yunnysunny · 2022-04-23T09:33:11Z

@yunnysunny pending results of https://github.com/visionmedia/superagent/actions/runs/2185564459, please follow up if we forget to version bump if successful

The action has passed. We can merge the request #1717 next.

yunnysunny · 2022-05-03T03:16:46Z

The test on Node 10 has been fixed with #1722

yunnysunny · 2022-05-08T06:08:59Z

The test with http2 has been fixed with #1723

feat: add github action

2704155

yunnysunny mentioned this pull request Jan 23, 2022

Feature/fix lookup #1674

Merged

titanism merged commit 451cdcd into ladjs:master Mar 29, 2022

SandorArpa mentioned this pull request Mar 31, 2022

[DO NOT MERGE] Bump superagent from 7.1.1 to 7.1.2 alphagov/pay-frontend#2782

Closed

pdehaan mentioned this pull request Apr 13, 2022

Investigate deprecated @hapi/joi package mozilla/fxa#12477

Closed

GraemeF added a commit to GraemeF/home-automation that referenced this pull request Apr 16, 2022

Downgrade superagent to 7.1.1 as 7.1.2 is deprecated

ec018ec

ladjs/superagent#1677

pdehaan mentioned this pull request Apr 18, 2022

Investigate deprecated superagent package mozilla/fxa#12543

Closed

mfacar mentioned this pull request Apr 18, 2022

Bump superagent from 6.1.0 to 7.1.2 huridocs/uwazi#4531

Closed

kkiilas mentioned this pull request Apr 23, 2022

updated dotenv, eslint, express, jest, mongoose and dependencies in part4-3 fullstack-hy2020/part3-notes-backend#12

Merged

beenotung mentioned this pull request Apr 24, 2022

Is superagent deprecated? #1719

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add github action #1677

feat: add github action #1677

yunnysunny commented Jan 21, 2022 •

edited

niftylettuce commented Jan 22, 2022

yunnysunny commented Jan 23, 2022 •

edited

yunnysunny commented Feb 10, 2022

titanism commented Mar 29, 2022

yunnysunny commented Mar 29, 2022 •

edited

titanism commented Mar 29, 2022

seancolyer commented Apr 1, 2022

yunnysunny commented Apr 2, 2022 •

edited

yunnysunny commented Apr 3, 2022

titanism commented Apr 18, 2022

priyanka-kahare-kr commented Apr 18, 2022

yunnysunny commented Apr 23, 2022

yunnysunny commented May 3, 2022

yunnysunny commented May 8, 2022

feat: add github action #1677

feat: add github action #1677

Conversation

yunnysunny commented Jan 21, 2022 • edited

niftylettuce commented Jan 22, 2022

yunnysunny commented Jan 23, 2022 • edited

yunnysunny commented Feb 10, 2022

titanism commented Mar 29, 2022

yunnysunny commented Mar 29, 2022 • edited

titanism commented Mar 29, 2022

seancolyer commented Apr 1, 2022

yunnysunny commented Apr 2, 2022 • edited

yunnysunny commented Apr 3, 2022

titanism commented Apr 18, 2022

priyanka-kahare-kr commented Apr 18, 2022

yunnysunny commented Apr 23, 2022

yunnysunny commented May 3, 2022

yunnysunny commented May 8, 2022

yunnysunny commented Jan 21, 2022 •

edited

yunnysunny commented Jan 23, 2022 •

edited

yunnysunny commented Mar 29, 2022 •

edited

yunnysunny commented Apr 2, 2022 •

edited