Skip to content

Commit 967aff1

Browse files
authoredJan 25, 2021
Merge pull request #704 from ktutnik/fix-array-flat-issue
fix: Fix unappropriate stack trace issue on Node.js prior than v14
2 parents abd2f45 + 0a06ef1 commit 967aff1

File tree

3 files changed

+8
-2
lines changed

3 files changed

+8
-2
lines changed
 

‎.travis.yml

+2
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@ language: node_js
55

66
node_js:
77
- lts/*
8+
- 12
9+
- 10
810

911
before_install:
1012
- npm i

‎lib/test.js

+5-1
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,11 @@ function wrapAssertFn(assertFn) {
8080
var err = assertFn(res);
8181
if (err && err.stack) {
8282
badStack = err.stack.replace(err.message, '').split('\n').slice(1);
83-
err.stack = [err.toString(), savedStack, '----', badStack].flat().join('\n');
83+
err.stack = [err.toString()]
84+
.concat(savedStack)
85+
.concat('----')
86+
.concat(badStack)
87+
.join('\n');
8488
}
8589
return err;
8690
};

‎test/supertest.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -531,7 +531,7 @@ describe('request(app)', function () {
531531
.get('/')
532532
.expect({ stringValue: 'foo', numberValue: 3, nestedObject: { innerString: 5 } })
533533
.end(function (err, res) {
534-
err.message.should.equal('expected {\n stringValue: \'foo\',\n numberValue: 3,\n nestedObject: { innerString: 5 }\n} response body, got {\n stringValue: \'foo\',\n numberValue: 3,\n nestedObject: { innerString: \'5\' }\n}'); // eslint-disable-line max-len
534+
err.message.replace(/[^a-zA-Z]/g, '').should.equal('expected {\n stringValue: \'foo\',\n numberValue: 3,\n nestedObject: { innerString: 5 }\n} response body, got {\n stringValue: \'foo\',\n numberValue: 3,\n nestedObject: { innerString: \'5\' }\n}'.replace(/[^a-zA-Z]/g, '')); // eslint-disable-line max-len
535535
shouldIncludeStackWithThisFile(err);
536536

537537
request(app)

0 commit comments

Comments
 (0)
Failed to load comments.