Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We shouldn't exact-pin the dependencies versions #677

Closed
julienw opened this issue Oct 8, 2020 · 0 comments · Fixed by #679 or newerton/gostack-template-fundamentos-node#15
Closed

Comments

@julienw
Copy link
Contributor

julienw commented Oct 8, 2020

This was changed in #601.

Hey @rimiti, any reason why you removed the ^ ? Without that symbol, this means you pin to that exact version. I don't mind much for devDependencies which are local to this project, but for dependencies this effectively locks them also for any project that depends on supertest.

The main issue is if one of these transitive dependencies has a security alert and fixes it with a minor version => we (downstream projects) won't be able to update it unless supertest does it too.

What do you think?

I'd be happy doing the change in a PR if you'd like.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment