Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: 100% coverage #792

Merged
merged 7 commits into from Oct 3, 2022
Merged

test: 100% coverage #792

merged 7 commits into from Oct 3, 2022

Conversation

lamweili
Copy link
Contributor

@lamweili lamweili commented Oct 3, 2022

@lamweili
fix(TestAgent): attach cookies to agent after plugin is used
6d9b9cb 
following superagent:
    PR: ladjs/superagent#1556
commit: ladjs/superagent@4babc5d
@lamweili
feat(TestAgent): decoupled TestAgent and superagent's Agent to suppor…
5e23869 
…t more than `ca`, `key`, `cert`

`options` object is now a direct passthrough, TestAgent can support whichever superagent's Agent is expecting
i.e. `ca`, `key`, `cert`, `pfx`, `rejectUnauthorized`
@lamweili
refactor(TestAgent): removed the host param when creating Test object
1c8930d 
`Test` constructor has already removed the host param in de056d2
@lamweili
test: 100% test coverage
8bf4c14
@lamweili
refactor(test): do not have both s and server, renamed to `server…
c1c4402 
…` for consistency
@lamweili
refactor(test): do not hardcode any ports, use ephemeral ports
8847310
@lamweili
ci: added ci
da1e842
@lamweili lamweili changed the title Refactor/test test: 100% coverage Oct 3, 2022
@titanism titanism merged commit b8c2e29 into ladjs:master Oct 3, 2022
@lamweili lamweili deleted the refactor/test branch October 3, 2022 20:15
@lamweili lamweili restored the refactor/test branch October 3, 2022 22:01
@lamweili lamweili deleted the refactor/test branch October 3, 2022 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lamweili @titanism