Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we allow directly accessing vis global object? #70

Open
qiankunxie opened this issue Mar 15, 2017 · 0 comments
Open

Should we allow directly accessing vis global object? #70

qiankunxie opened this issue Mar 15, 2017 · 0 comments

Comments

@qiankunxie
Copy link

Currently we need to access vis object from global scope, for angular, should we make a service wrapper for vis object?

        .factory('vis', ['$window', function($window) {
            if (!$window.vis) {
                console.log("error loading library");
                return {};
            }
        	return $window.vis;
        }])
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant