Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calling setOptions() hides the rolling mode button #1605

Open
bpfoster opened this issue Mar 29, 2023 · 0 comments · May be fixed by #1608
Open

Calling setOptions() hides the rolling mode button #1605

bpfoster opened this issue Mar 29, 2023 · 0 comments · May be fixed by #1608

Comments

@bpfoster
Copy link
Contributor

If the timeline is currently not rolling and the rolling button is being shown, and something calls setOptions(), the rolling button goes away, and the user has no way to re-enable it.

vis-timeline/lib/timeline/Core.js

Line 424 in eaf31b7

this.dom.rollingModeBtn.style.visibility = 'hidden';

bpfoster added a commit to bpfoster/vis-timeline that referenced this issue Mar 30, 2023
@bpfoster
Do not hide rollingMode button when calling setOptions
e0c79c8 
fixes visjs#1605
@bpfoster bpfoster linked a pull request Mar 30, 2023 that will close this issue
Open
bpfoster added a commit to bpfoster/vis-timeline that referenced this issue Jun 6, 2023
@bpfoster
Do not hide rollingMode button when calling setOptions
befc8c2 
fixes visjs#1605
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Do not hide rollingMode button when calling setOptions bpfoster/vis-timeline
1 participant
@bpfoster