Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

customTime no longer accepts options #1764

Open
barreeeiroo opened this issue Jan 28, 2024 · 0 comments
Open

customTime no longer accepts options #1764

barreeeiroo opened this issue Jan 28, 2024 · 0 comments

Comments

@barreeeiroo
Copy link

I was looking for ways to make my customTime not editable (i.e., so that users won't be dragging that item), and I came up with the following commit:

This commit added the possibility of passing an options object so that {editable: false} would disable this drag-and-drop functionality. However, when using the library, passing this seems to have no effect. And after investigating a bit more, this change was later removed by the following commit:

Not sure if this change was intentional, but it seems like it could have been removed by mistake (no documentation highlights the opposite, and I couldn't find any discussion or issue where this removal was documented).

Are there any concerns on bringing it back?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant