Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more tests #6

Open
mojoaxel opened this issue Jul 14, 2019 · 3 comments
Open

more tests #6

mojoaxel opened this issue Jul 14, 2019 · 3 comments
Assignees
Labels
enhancement New feature or request Hacktoberfest hacktoberfest.digitalocean.com

Comments

@mojoaxel
Copy link
Member

It would be nice and more secure if we move code in the future if every function would have its own test - ideal in its own test-file.

@mojoaxel mojoaxel added the enhancement New feature or request label Jul 14, 2019
@mojoaxel mojoaxel changed the title Update tests more tests Jul 14, 2019
@mojoaxel mojoaxel mentioned this issue Jul 16, 2019
@Thomaash
Copy link
Member

Thomaash commented Aug 3, 2019

🎆 Our test coverage is all green. 🎆

+ Statements   : 82.51% ( 453/549 )
+ Branches     : 81.21% ( 376/463 )
+ Functions    : 81.93% ( 68/83 )
+ Lines        : 82.59% ( 446/540 )

PS: There are still two unmerged tests to make it even better.

@mojoaxel
Copy link
Member Author

mojoaxel commented Aug 3, 2019

It would have been better to have these test coverage before the TS rewrite!
But better late than never 🤣

@Thomaash
Copy link
Member

Thomaash commented Aug 3, 2019

Yeah, that's what I plan to do in vis-network. Tests first, TS later.

@mojoaxel mojoaxel added the Hacktoberfest hacktoberfest.digitalocean.com label Oct 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Hacktoberfest hacktoberfest.digitalocean.com
Projects
None yet
Development

No branches or pull requests

2 participants