Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Update to Playwright@1.43.1 #146

Open
synnksou opened this issue Apr 26, 2024 · 1 comment
Open

Feature: Update to Playwright@1.43.1 #146

synnksou opened this issue Apr 26, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@synnksou
Copy link

synnksou commented Apr 26, 2024

The problem
Incompatibility between the Page type on Axebuilder and Playwight-bdd, Axe expects a Page type 1.43.1 whereas the step gives a 1.42.1 page.
image

on this code

When("The user needs the page to be accessiblee", async ({ page }) => { // Page 1.42
  const accessibilityScanResults = await new AxeBuilder({ page }).analyze(); // Error on page want version 1.43
...});

A solution

Upgrade the PlaywrightType to 1.43.1 ?

I can open a pull request to handle the issue @vitalets :)

@synnksou synnksou added the enhancement New feature or request label Apr 26, 2024
@vitalets
Copy link
Owner

@synnksou steps should pass Page from the Playwright installed in the project. Could you check why there are two versions of Playwright? For example npm ls playwright-core.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants