Error not being thrown when statement cancelled due to timeout

[0x-jj]

Expected behavior

An error is thrown when a statement is cancelled due to a timeout

Actual behavior

No error is thrown

Steps to reproduce

try {
await idb.tx((t) => {
      const lockTimeout = t.none("SET LOCAL lock_timeout = '2s'");
      const q = t.none(query); // This causes an ERROR to be logged by the db and the statement is cancelled due to the lock timeout
      return t.batch([lockTimeout, q]);
    });
} catch (err) {
// No error is thrown
console.log(err)
}

Environment

• Version of pg-promise: ^11.2.0
• OS type (Linux/Windows/Mac): Linux, aws lambda
• Version of Node.js: 16

[vitaly-t]

If you're not getting an error, it means that the underlying driver doesn't throw one. Whether it is a bug in the driver or something else, it is a little out of scope here. I suggest you check with the driver, and open a ticket there.

[vitaly-t]

This addition made it into the latest version. So if you are really using 11.2 (i'd check it), then it should work, somehow. Or maybe it is a separate feature, I'm not sure, you'll need to research.

[0x-jj]

This addition made it into the latest version. So if you are really using 11.2 (i'd check it), then it should work, somehow. Or maybe it is a separate feature, I'm not sure, you'll need to research.

Interesting

I'm definitely on 11.2, though I don't see the lock_timeout supported when constructing the pgpromise config

Typescript says Object literal may only specify known properties, and 'lock_timeout' does not exist in type 'IConnectionParameters<IClient>

Is this just a typing thing and you expect it to still be passed down to the driver?

import PgPromise from 'pg-promise';

const pgp = PgPromise();

export const db = pgp({
  connectionString: config.databaseUrl,
  keepAlive: true,
  max: 10,
  connectionTimeoutMillis: 30 * 1000,
  query_timeout: 5 * 60 * 1000,
  allowExitOnIdle: true,
  lock_timeout: 5 * 60 * 1000, // has typescript error
});

[vitaly-t]

Is this just a typing thing and you expect it to still be passed down to the driver?

It was indeed an omission in TypeScript declaration, patched in v11.3.0.

[0x-jj]

Is this just a typing thing and you expect it to still be passed down to the driver?

It was indeed an omission in TypeScript declaration, patched in v11.3.0.

Great, thanks!