Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specyfing different theme colors in manifest for dark mode #104

Open
DamianGlowala opened this issue Dec 5, 2023 · 1 comment
Open

Specyfing different theme colors in manifest for dark mode #104

DamianGlowala opened this issue Dec 5, 2023 · 1 comment

Comments

@DamianGlowala
Copy link

As per note in this section:

image

... it would be a nice addition to be able to adjust for the dark mode. Not sure which properties can be adjusted this way though (whether it is only the theme_color and background_color or other as well).

@userquin
Copy link
Member

userquin commented Dec 8, 2023

Right now there is no way to add theme variants to webmanifest, you can only create them.

We have it working in elk.zone GH repo with 2 web manifest per locale (i18n + theme variants): https://github.com/elk-zone/elk/blob/main/modules/pwa/i18n.ts

You need to disable manifest entry (manifest: false) and register them manually:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants