Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please document that images that are outside of /static will NOT build in production #78

Open
rbozan opened this issue Feb 25, 2024 · 2 comments

Comments

@rbozan
Copy link

rbozan commented Feb 25, 2024

Having the same file but then in a map outside of static like /images/favicon.svg will work in development mode but fail while building. This does not seem to be documented.

@userquin
Copy link
Member

userquin commented Feb 25, 2024

https://vite-pwa-org.netlify.app/guide/static-assets.html

publicDir in kit is static folder

@rbozan
Copy link
Author

rbozan commented Feb 25, 2024

I don't know but I personally found it confusing. It's not stated here for example https://vite-pwa-org.netlify.app/frameworks/sveltekit.html#pwa-assets or https://github.com/vite-pwa/assets-generator (even though it's not Sveltekit specific). And it actually works in development mode without errors so that really didn't help either. Just talking from an user-perspective

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants