Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add vite resolve option when building custom sw #530

Merged
merged 1 commit into from Jun 2, 2023
Merged

fix: Add vite resolve option when building custom sw #530

merged 1 commit into from Jun 2, 2023

Conversation

arsonik
Copy link
Contributor

@arsonik arsonik commented Jun 2, 2023

fix #529

@netlify
Copy link

netlify bot commented Jun 2, 2023 •
edited

✅ Deploy Preview for vite-plugin-pwa-legacy ready!

Name Link
🔨 Latest commit e6b0646
🔍 Latest deploy log https://app.netlify.com/sites/vite-plugin-pwa-legacy/deploys/6479aa615266b80008d17a20
😎 Deploy Preview https://deploy-preview-530--vite-plugin-pwa-legacy.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

userquin
userquin approved these changes Jun 2, 2023
View reviewed changes
Copy link
Member

@userquin userquin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need to add some test, I'll try to add it later (to all fw examples)

@userquin userquin changed the title Add vite resolve option to fix typescript alias fix: Add vite resolve option when building custom sw Jun 2, 2023
@userquin userquin merged commit 4bea05b into vite-pwa:main Jun 2, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@userquin userquin userquin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Typescript alias issues
2 participants
@arsonik @userquin