Run configureStaticAssets when includeAssets option is true regardless of manifest option. #612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s of manifest option.
✅ Deploy Preview for vite-plugin-pwa-legacy ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
@sgpinkus I've been busy, I'll merge this PR and release a new patch tmr |
userquin
changed the title
includeAssets option is true regardless of manifest option
userquin
changed the title
includeAssets option is true regardless of manifest optionincludeAssets option is true regardless of manifest option
userquin
changed the title
includeAssets option is true regardless of manifest option
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes one line conditional enabling collection of static assets.
Currently
includeAssetsoption has no effect unlessmanifestis also set. This makes it impossible to include additional assets while managing your own manifest file.