feat!: new custom service worker build #629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vite-plugin-pwa-legacy ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Closed
userquin
changed the title
This was referenced Dec 30, 2023
Doctor-wu
reviewed
Dec 31, 2023
userquin
commented
Jan 6, 2024
# Conflicts: # package.json
|
@userquin thank you for resolving the linked issues. When can we expect this to be released as v0.18? Also, is there a way to use this in a project somehow, maybe through a |
renovate bot
added a commit
to SebastianGoeb/chinese-chart
that referenced
this pull request
Feb 12, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [vite-plugin-pwa](https://togithub.com/vite-pwa/vite-plugin-pwa) | [`^0.17.4` -> `^0.18.0`](https://renovatebot.com/diffs/npm/vite-plugin-pwa/0.17.5/0.18.1) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>vite-pwa/vite-plugin-pwa (vite-plugin-pwa)</summary> ### [`v0.18.1`](https://togithub.com/vite-pwa/vite-plugin-pwa/releases/tag/v0.18.1) [Compare Source](https://togithub.com/vite-pwa/vite-plugin-pwa/compare/v0.18.0...v0.18.1) ##### 🐞 Bug Fixes - Handle Vite's base properly in dev server - by [@​userquin](https://togithub.com/userquin) in [vite-pwa/vite-plugin-pwa#657 [<samp>(8cac9)</samp>](https://togithub.com/vite-pwa/vite-plugin-pwa/commit/8cac935) ##### [View changes on GitHub](https://togithub.com/vite-pwa/vite-plugin-pwa/compare/v0.18.0...v0.18.1) ### [`v0.18.0`](https://togithub.com/vite-pwa/vite-plugin-pwa/releases/tag/v0.18.0) [Compare Source](https://togithub.com/vite-pwa/vite-plugin-pwa/compare/v0.17.5...v0.18.0) ##### 🚨 Breaking Changes - New custom service worker build - by [@​userquin](https://togithub.com/userquin) in [vite-pwa/vite-plugin-pwa#629 [<samp>(865fd)</samp>](https://togithub.com/vite-pwa/vite-plugin-pwa/commit/865fdad) ##### 🐞 Bug Fixes - Register client module and prompt - by [@​userquin](https://togithub.com/userquin) in [vite-pwa/vite-plugin-pwa#633 [<samp>(b3474)</samp>](https://togithub.com/vite-pwa/vite-plugin-pwa/commit/b347432) ##### [View changes on GitHub](https://togithub.com/vite-pwa/vite-plugin-pwa/compare/v0.17.5...v0.18.0) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 4am on Monday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/SebastianGoeb/chinese-chart). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xNzMuMCIsInVwZGF0ZWRJblZlciI6IjM3LjE3My4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After some digging, we found the problem in
esbuildand the solution:.mjsextension instead.js.mjsfile to the original after the build.mjs.mapwhen sourcemap file generatedThanks to @benmccann for filing the issue on Vite vitejs/vite#15379 and @Rich-Harris for the solution on SvelteKit sveltejs/kit#11400, this PR is a copy of the SvelteKit solution.
This PR also includes:
pluginsincluding newbuildPluginsoption for Rollup and Vite plugins: added an example and the corresponding test in vue-route example using Vite plugin with a simple virtual moduleNOTE: added
lodash-esto test it in Vite ecosystem-ci.closes #566
closes #571
closes #575
closes #615
closes #625
closes #655
supersedes #572