fix(dev): inject register not working when disabling web manifest #686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vite-plugin-pwa-legacy ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Gave this a quick test but it doesn't seem to correct the issue, unless I'm being daft (perfectly possible). |
I'm preparing some tests in my local, will take some time... |
|
No worries or rush! Just thought I'd comment that |
|
I need to change also the |
With last commit should work: tested with |
renovate bot
added a commit
to SebastianGoeb/chinese-chart
that referenced
this pull request
Mar 18, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [vite-plugin-pwa](https://togithub.com/vite-pwa/vite-plugin-pwa) | [`0.19.2` -> `0.19.4`](https://renovatebot.com/diffs/npm/vite-plugin-pwa/0.19.2/0.19.4) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>vite-pwa/vite-plugin-pwa (vite-plugin-pwa)</summary> ### [`v0.19.4`](https://togithub.com/vite-pwa/vite-plugin-pwa/releases/tag/v0.19.4) [Compare Source](https://togithub.com/vite-pwa/vite-plugin-pwa/compare/v0.19.3...v0.19.4) ##### 🐞 Bug Fixes - **dev**: Inject register not working when disabling web manifest - by [@​userquin](https://togithub.com/userquin) in [vite-pwa/vite-plugin-pwa#686 [<samp>(293db)</samp>](https://togithub.com/vite-pwa/vite-plugin-pwa/commit/293db14) ##### [View changes on GitHub](https://togithub.com/vite-pwa/vite-plugin-pwa/compare/v0.19.3...v0.19.4) ### [`v0.19.3`](https://togithub.com/vite-pwa/vite-plugin-pwa/releases/tag/v0.19.3) [Compare Source](https://togithub.com/vite-pwa/vite-plugin-pwa/compare/v0.19.2...v0.19.3) ##### 🐞 Bug Fixes - Pwa assets disabled when using inlined configuration - by [@​userquin](https://togithub.com/userquin) in [vite-pwa/vite-plugin-pwa#685 [<samp>(7ffeb)</samp>](https://togithub.com/vite-pwa/vite-plugin-pwa/commit/7ffeb44) ##### [View changes on GitHub](https://togithub.com/vite-pwa/vite-plugin-pwa/compare/v0.19.2...v0.19.3) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 4am on Monday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/SebastianGoeb/chinese-chart). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yNDUuMCIsInVwZGF0ZWRJblZlciI6IjM3LjI0NS4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
This was referenced May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #660