Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support MDX #52

Closed
ArnaudBarre opened this issue Feb 3, 2023 · 3 comments
Closed

Support MDX #52

ArnaudBarre opened this issue Feb 3, 2023 · 3 comments

Comments

@ArnaudBarre
Copy link
Member

Re: storybookjs/builder-vite#552
@IanVS
Copy link

IanVS commented Feb 3, 2023

I haven't looked into whether this is an issue with the way Storybook is rendering MDX or this plugin itself.

@ArnaudBarre
Copy link
Member Author

I think this would work because mdx output runnable JS but fast refresh will not work

@IanVS
Copy link

IanVS commented Feb 7, 2023

Yeah it was indeed a bug in Storybook, that should be fixed in storybookjs/builder-vite#556. I've tested it in our examples, and it works fine. fast-refresh might not work, but the reload is nice and fast.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@IanVS @ArnaudBarre