fix: avoid key collision in React refresh registration (fix #116)

vitejs · Mar 11, 2023 · a74dfef · a74dfef
1 parent b5945c9
commit a74dfef
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/packages/plugin-react/src/refreshUtils.js b/packages/plugin-react/src/refreshUtils.js
@@ -25,7 +25,11 @@ function registerExportsForReactRefresh(filename, moduleExports) {
     if (key === '__esModule') continue
     const exportValue = moduleExports[key]
     if (exports.isLikelyComponentType(exportValue)) {
-      exports.register(exportValue, filename + ' ' + key)
+      // 'export' is required to avoid key collision when renamed exports that
+      // shadow a local component name: https://github.com/vitejs/vite-plugin-react/issues/116
+      // The register function has an identity check to not register twice the same component,
+      // so this is safe to not used the same key here.
+      exports.register(exportValue, filename + ' export ' + key)
     }
   }
 }