-
-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: don't invalidate when code is invalid #67
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have the same condition in react-swc plugin 👍
any date for next release with this fix? |
@patak-dev we are also facing the same issue and waiting for a release, as manually installing this package from github doesn't work with a monorepo. |
Same here, would be great to see this released soon. |
Available in 3.0.1! |
Thank you @ArnaudBarre |
I still have the same issue vitejs/vite#11365 that vite gets stuck in an invalidating loop. |
I will check if it's still happening with #79 My advice is to stop doing barrels imports. Took me some hours when migrating from CRA, but that was worth it. Imports are not as beautiful, but with time you learn to don't care and IDE renaming/find usages & HMR works a lot better |
Description
This PR adds
if (!mod) return
to fix invalidate happening.This fixes vitejs/vite#11365.
Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).