Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make it work when a default lang was specified #223

Merged
merged 1 commit into from Aug 11, 2023
Merged

fix: make it work when a default lang was specified #223

merged 1 commit into from Aug 11, 2023

Conversation

dargmuesli
Copy link
Contributor

Description

Resolved merge conflicts for #65.


<template lang="html">
  <div>foo</div>
</script>

and

<script setup lang="js">
const foo = 'foo'
</script>

didn't work.
This PR fixes these.

requires vuejs/core#7388
fixes #17

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red added the p3-minor-bug 🔨 An edge case that only affects very specific usage (priority) label Aug 9, 2023
Copy link
Member

@sapphi-red sapphi-red left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@sapphi-red sapphi-red requested a review from sodatea August 9, 2023 08:56
@sodatea sodatea merged commit ff68ed3 into vitejs:main Aug 11, 2023
7 checks passed
@dargmuesli dargmuesli deleted the fix/default-langs-specified branch August 13, 2023 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p3-minor-bug 🔨 An edge case that only affects very specific usage (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: template uses lang html for template, however it is not installed
3 participants