HMR infinite loop inside deepEqual

[aguingand]

Related plugins

• plugin-vue

• plugin-vue-jsx

Describe the bug

I can reproduce an infinite loop during HMR. I have located the loop inside deepEqual function introduced in (#258 and #334). It seems to appear when importing third-party library (here radix-vue / vue) because it recursively walk through the AST of the library components / TS definitions (non-project file).

Related issue #350.

Reproduction

https://stackblitz.com/edit/vite-plugin-vue-hmr-inifite-loop-repro

Steps to reproduce

• Edit src/App.vue HMR works
• Edit src/components/ui/alert-dialog/AlertDialog.vue HMR hangs

System Info

System:
    OS: macOS 12.7.4
    CPU: (8) x64 Intel(R) Core(TM) i7-6700HQ CPU @ 2.60GHz
    Memory: 1.88 GB / 16.00 GB
    Shell: 5.8.1 - /bin/zsh
  Binaries:
    Node: 20.12.2 - ~/.nvm/versions/node/v20.12.2/bin/node
    npm: 10.7.0 - ~/.nvm/versions/node/v20.12.2/bin/npm
    pnpm: 8.15.8 - ~/.nvm/versions/node/v20.12.2/bin/pnpm
  npmPackages:
    @vitejs/plugin-vue: ^5.0.4 => 5.0.4
    vite: ^5.2.11 => 5.2.11

Used Package Manager

npm

Logs

No response

Validations

• Follow our Code of Conduct
• Read the Contributing Guidelines.
• Read the docs.
• Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
• Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to vuejs/core instead.
• Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
• The provided reproduction is a minimal reproducible example of the bug.

[aguingand]

I've updated system infos, it occurs in latest version (5.0.4). Version 4.6.2 is not affected.

[elliots]

I'm seeing this in our project too

[sxzz]

/cc @sodatea