From 0c928aa079df5060c5bc7a745a128be62fd86cd2 Mon Sep 17 00:00:00 2001 From: Haoqun Jiang Date: Tue, 12 Apr 2022 17:29:25 +0800 Subject: [PATCH] refactor: esbuild handles `target` and `useDefineForClassFields` (#7698) --- packages/vite/src/node/plugins/esbuild.ts | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/packages/vite/src/node/plugins/esbuild.ts b/packages/vite/src/node/plugins/esbuild.ts index db216c7d6b0d77..c982b4e61f30c8 100644 --- a/packages/vite/src/node/plugins/esbuild.ts +++ b/packages/vite/src/node/plugins/esbuild.ts @@ -81,6 +81,7 @@ export async function transformWithEsbuild( // these fields would affect the compilation result // https://esbuild.github.io/content-types/#tsconfig-json const meaningfulFields: Array = [ + 'target', 'jsxFactory', 'jsxFragmentFactory', 'useDefineForClassFields', @@ -98,17 +99,9 @@ export async function transformWithEsbuild( compilerOptionsForFile[field] = loadedCompilerOptions[field] } } - - // align with TypeScript 4.3 - // https://github.com/microsoft/TypeScript/pull/42663 - if (loadedCompilerOptions.target?.toLowerCase() === 'esnext') { - compilerOptionsForFile.useDefineForClassFields = - loadedCompilerOptions.useDefineForClassFields ?? true - } } tsconfigRaw = { - ...tsconfigRaw, compilerOptions: { ...compilerOptionsForFile, ...tsconfigRaw?.compilerOptions