fix: set isSelfAccepting to false for any asset not processed by …

…importAnalysis (#7898)
vitejs · Apr 25, 2022 · 0d2089c · 0d2089c
1 parent 54728e3
commit 0d2089c
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/packages/vite/src/node/plugins/importAnalysis.ts b/packages/vite/src/node/plugins/importAnalysis.ts
@@ -59,7 +59,8 @@ const debug = createDebugger('vite:import-analysis')
 const clientDir = normalizePath(CLIENT_DIR)
 
 const skipRE = /\.(map|json)$/
-const canSkip = (id: string) => skipRE.test(id) || isDirectCSSRequest(id)
+export const canSkipImportAnalysis = (id: string) =>
+  skipRE.test(id) || isDirectCSSRequest(id)
 
 const optimizedDepChunkRE = /\/chunk-[A-Z0-9]{8}\.js/
 const optimizedDepDynamicRE = /-[A-Z0-9]{8}\.js/
@@ -131,7 +132,7 @@ export function importAnalysisPlugin(config: ResolvedConfig): Plugin {
       const ssr = options?.ssr === true
       const prettyImporter = prettifyUrl(importer, root)
 
-      if (canSkip(importer)) {
+      if (canSkipImportAnalysis(importer)) {
         isDebug && debug(colors.dim(`[skipped] ${prettyImporter}`))
         return null
       }

diff --git a/packages/vite/src/node/server/moduleGraph.ts b/packages/vite/src/node/server/moduleGraph.ts
@@ -11,6 +11,7 @@ import {
 } from '../utils'
 import { FS_PREFIX } from '../constants'
 import type { TransformResult } from './transformRequest'
+import { canSkipImportAnalysis } from '../plugins/importAnalysis'
 
 export class ModuleNode {
   /**
@@ -39,9 +40,9 @@ export class ModuleNode {
     this.url = url
     this.type = isDirectCSSRequest(url) ? 'css' : 'js'
     // #7870
-    // The `isSelfAccepting` value is set by importAnalysis, but HTML
+    // The `isSelfAccepting` value is set by importAnalysis, but some
     // assets don't go through importAnalysis.
-    if (isHTMLRequest(url)) {
+    if (isHTMLRequest(url) || canSkipImportAnalysis(url)) {
       this.isSelfAccepting = false
     }
   }