From 0f1d6be100e3d6fda391b024ec14d2b4091993cb Mon Sep 17 00:00:00 2001 From: Ben McCann <322311+benmccann@users.noreply.github.com> Date: Wed, 1 Sep 2021 05:21:02 -0700 Subject: [PATCH] fix: apply SSR externalization heuristic to devDependencies (#4699) --- packages/vite/src/node/ssr/ssrExternal.ts | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/packages/vite/src/node/ssr/ssrExternal.ts b/packages/vite/src/node/ssr/ssrExternal.ts index 4c3b40e1915a9a..0ef48c168439b0 100644 --- a/packages/vite/src/node/ssr/ssrExternal.ts +++ b/packages/vite/src/node/ssr/ssrExternal.ts @@ -28,14 +28,12 @@ export function resolveSSRExternal( return [] } const pkg = JSON.parse(pkgContent) - const devDeps = Object.keys(pkg.devDependencies || {}) const importedDeps = knownImports.map(getNpmPackageName).filter(isDefined) - const deps = unique([...importedDeps, ...Object.keys(pkg.dependencies || {})]) - - for (const id of devDeps) { - ssrExternals.add(id) - seen.add(id) - } + const deps = unique([ + ...importedDeps, + ...Object.keys(pkg.devDependencies || {}), + ...Object.keys(pkg.dependencies || {}) + ]) const resolveOptions: InternalResolveOptions = { root,