From 10300499011af9165f9e6b02c1841835dc0b4fbc Mon Sep 17 00:00:00 2001 From: patak Date: Wed, 22 Mar 2023 07:01:42 +0100 Subject: [PATCH] perf: remove regex in ImportMetaURL plugins (#12502) --- packages/vite/src/node/plugins/assetImportMetaUrl.ts | 2 +- packages/vite/src/node/plugins/workerImportMetaUrl.ts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/vite/src/node/plugins/assetImportMetaUrl.ts b/packages/vite/src/node/plugins/assetImportMetaUrl.ts index 00aa1c466c406b..215605fa747181 100644 --- a/packages/vite/src/node/plugins/assetImportMetaUrl.ts +++ b/packages/vite/src/node/plugins/assetImportMetaUrl.ts @@ -52,7 +52,7 @@ export function assetImportMetaUrlPlugin(config: ResolvedConfig): Plugin { if (!s) s = new MagicString(code) // potential dynamic template string - if (rawUrl[0] === '`' && /\$\{/.test(rawUrl)) { + if (rawUrl[0] === '`' && rawUrl.includes('${')) { const ast = this.parse(rawUrl) const templateLiteral = (ast as any).body[0].expression if (templateLiteral.expressions.length) { diff --git a/packages/vite/src/node/plugins/workerImportMetaUrl.ts b/packages/vite/src/node/plugins/workerImportMetaUrl.ts index 37ccc8a015283b..a01e8d6e066003 100644 --- a/packages/vite/src/node/plugins/workerImportMetaUrl.ts +++ b/packages/vite/src/node/plugins/workerImportMetaUrl.ts @@ -126,7 +126,7 @@ export function workerImportMetaUrlPlugin(config: ResolvedConfig): Plugin { const rawUrl = code.slice(urlStart, urlEnd) // potential dynamic template string - if (rawUrl[0] === '`' && /\$\{/.test(rawUrl)) { + if (rawUrl[0] === '`' && rawUrl.includes('${')) { this.error( `\`new URL(url, import.meta.url)\` is not supported in dynamic template string.`, urlIndex,