Skip to content

Commit 1638ebd

Browse files
authoredApr 1, 2023
fix(import-analysis): escape quotes correctly (#12688)
1 parent a3150ee commit 1638ebd

File tree

2 files changed

+8
-6
lines changed

2 files changed

+8
-6
lines changed
 

‎packages/vite/src/node/plugins/importAnalysis.ts

+4-3
Original file line numberDiff line numberDiff line change
@@ -589,9 +589,10 @@ export function importAnalysisPlugin(config: ResolvedConfig): Plugin {
589589
rewriteDone = true
590590
}
591591
if (!rewriteDone) {
592-
let rewrittenUrl = JSON.stringify(url)
593-
if (!isDynamicImport) rewrittenUrl = rewrittenUrl.slice(1, -1)
594-
str().overwrite(start, end, rewrittenUrl, {
592+
const rewrittenUrl = JSON.stringify(url)
593+
const s = isDynamicImport ? start : start - 1
594+
const e = isDynamicImport ? end : end + 1
595+
str().overwrite(s, e, rewrittenUrl, {
595596
contentOnly: true,
596597
})
597598
}

‎packages/vite/src/node/plugins/importAnalysisBuild.ts

+4-3
Original file line numberDiff line numberDiff line change
@@ -342,9 +342,10 @@ export function buildImportAnalysisPlugin(config: ResolvedConfig): Plugin {
342342
rewriteDone = true
343343
}
344344
if (!rewriteDone) {
345-
let rewrittenUrl = JSON.stringify(file)
346-
if (!isDynamicImport) rewrittenUrl = rewrittenUrl.slice(1, -1)
347-
str().update(start, end, rewrittenUrl)
345+
const rewrittenUrl = JSON.stringify(file)
346+
const s = isDynamicImport ? start : start - 1
347+
const e = isDynamicImport ? end : end + 1
348+
str().update(s, e, rewrittenUrl)
348349
}
349350
}
350351
}

0 commit comments

Comments
 (0)
Please sign in to comment.